This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Revert "Merge pull request #3381 from jumpeiMano/set-sync-timeout" #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf97726, reversing changes made to 5777baa. Signed-off-by: Kingdon Barrett <[email protected]>
hiddeco
approved these changes
Jul 12, 2021
|
According to #3500, this was probably not the fix required. I'm going to close it without merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3500 a reporter indicates that one of the PRs merged into 1.22.2 was harmful, and causes orphaned data to grow the ephemeral filesystems without cleaning them up. The report says the context was already wrapped in a timeout; I have not been able to spend time to reproduce this issue or delve into the details myself yet.
If this is all correct, I will revert the bad PR and plan to have a new release out early this week.
This reverts commit cf97726, reversing
changes made to 5777baa.